Skip to content

Fix tweak visibility filtering (#867)#898

Open
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
breshinotestachegira:fix/issue-867-tweak-filter
Open

Fix tweak visibility filtering (#867)#898
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
breshinotestachegira:fix/issue-867-tweak-filter

Conversation

@breshinotestachegira
Copy link
Copy Markdown

Closes #867

Summary

This PR fixes tweak visibility/filtering so "Show tweaks" and related list filtering use the same detection logic.

Changes

  • add a single IsScriptTweak property to ApplicationUninstallerEntry
  • use that property in the main list filtering logic
  • use that property for the "View tweaks" command
  • use that property when checking whether any tweaks are present
  • add a regression test for tweak ID detection

Why

Tweak entries currently use RatingId = "Tweak-...", but different parts of the UI were using inconsistent detection logic:

  • one place checked tweak IDs case-insensitively
  • another checked them case-sensitively
  • another still relied on an old uninstall-string path pattern

Because of that, tweaks could stay visible even when "Show tweaks" was disabled.

Result

Tweaks are now detected consistently across:

  • sidebar visibility
  • basic filtering
  • "View tweaks"
  • equivalent filter generation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BCUninstaller 6.1 - Show Tweaks non functional, always visible

1 participant